feat/filedata metadata support #26
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n use Any for content
six5532one
reviewed
Oct 25, 2024
| usage=usage, | ||
| filedata_meta=filedata_meta_model.model_validate(filedata_meta.model_dump()), | ||
| status_code=status.HTTP_200_OK, | ||
| output=output, |
There was a problem hiding this comment.
I thought FileData is returned in the output. If so, why does filedata_metadata have a new_records field for FileData?
There was a problem hiding this comment.
In most scenarios, the output of a generic plugin wouldn't include the FileData, just some input/output content. This allows for communication to take place that doesn't follow into that pattern, such as the plugin generating new FileData content.
vangheem
approved these changes
Oct 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
To support providing additional information as part of the plugin invocation without it being directly tied to the input/output model, a metadata base model is dynamically passed in if the wrapped method is expecting it.
New models added: